search

hashicorp / terraform-aws-vault

A Terraform Module for how to run Vault on AWS using Terraform and Packer
Apache License 2.0
656 stars 465 forks source link

Bump tf to version 1.0 #248

Closed bwhaley closed 3 years ago

bwhaley commented 3 years ago

Updates tests to use Terraform 1.0.

rileytg commented 3 years ago

this will break variables in at least here https://github.com/hashicorp/terraform-aws-vault/tree/master/modules/vault-cluster

╷
│ Error: Invalid quoted type constraints
│ 
│   on .terraform/modules/vault_cluster/modules/vault-cluster/variables.tf line 24, in variable "allowed_inbound_cidr_blocks":
│   24:   type        = "list"
│ 
│ Terraform 0.11 and earlier required type constraints to be given in quotes, but that form is now deprecated and will be removed in a future version of
│ Terraform. Remove the quotes around "list" and write list(string) instead to explicitly indicate that the list elements are strings.

opening a pull for that now

rileytg commented 3 years ago

scratch that... im working off old code. everything i use is working with tf 1!

brikis98 commented 3 years ago

@bwhaley Looks like there were some test failures

bwhaley commented 3 years ago

Mind kicking off the tests again?

brikis98 commented 3 years ago

Tests are running again!

bwhaley commented 3 years ago

Tests appear to be passing.

brikis98 commented 3 years ago

Indeed they are! Merging now.

brikis98 commented 3 years ago

https://github.com/hashicorp/terraform-aws-vault/releases/tag/v0.17.0