hashicorp / terraform-aws-vault

A Terraform Module for how to run Vault on AWS using Terraform and Packer
Apache License 2.0
656 stars 465 forks source link

Fix versioning for S3 bucket #263

Closed T0tt1 closed 2 years ago

T0tt1 commented 2 years ago

New Provider expect separate resource for versioning instead of place the statement inside the resource for bucket createtion.

Description

Newest version of TF Provider introduced some changes into the way we manage S3 bucket and its policies, versioning and acl. This PR aims to fix the discrepancy which has been presented once the new provider has been introduced.

Documentation

TODOs

Please ensure all of these TODOs are completed before asking for a review.

Related Issues

Fixes #262