hashicorp / terraform-aws-vault

A Terraform Module for how to run Vault on AWS using Terraform and Packer
Apache License 2.0
656 stars 465 forks source link

Add optional parameter for unauthenticated metrics access #267

Open vgsantoniazzi opened 2 years ago

vgsantoniazzi commented 2 years ago

Description

There's no way to generate unauthenticated metrics access. I've tried to use the merge config files but it seems that the "tcp" listener got overridden by the second file.

Open issue: https://github.com/hashicorp/vault/issues/5860

Documentation

TODOs

Please ensure all of these TODOs are completed before asking for a review.

Related Issues

hashicorp-cla commented 2 years ago

CLA assistant check
All committers have signed the CLA.

TomGudman commented 2 years ago

Cool! Exactly what were going to do! Thank you!

rcousens commented 2 years ago

Would love to see this merged as it is the last stumbling block in automating our metrics setup for vault!

vgsantoniazzi commented 2 years ago

@rcousens replaced the underscore with hyphens. Does it look good now?

vgsantoniazzi commented 2 years ago

@robmorgan can you take a look?