hashicorp / terraform-cdk

Define infrastructure resources using programming constructs and provision them using HashiCorp Terraform
https://www.terraform.io/cdktf
Mozilla Public License 2.0
4.87k stars 455 forks source link

Add pre-compiled binaries for Nodejs v19 (for newly introduced `node-pty` dependency) #2441

Closed ansgarm closed 1 year ago

ansgarm commented 1 year ago

Community Note

Description

cdktf-cli v0.15 is going to change the way the Terraform CLI is invoked when deploying infrastucture (#1955). The new implementation relies on invoking the Terraform CLI interactively using node-pty. We currently use the package node-pty-prebuilt-multiarch which includes pre-compiled binaries for the native code used by node-pty to allow installing cdktf-cli without having tooling available to compile C code.

Unfortunately node-pty-prebuilt-multiarch does not contain bindings for Nodejs v19 and we also prefer to stay in control over those binaries, which is why we forked that package.

The package node-pty-prebuilt-multiarch uses two approaches (prebuild and prebuildify) to build and ship pre-compiled binaries, whereas nowadays prebuildify apparently is the recommended way to go.

We have an open PR in our fork that switches to using only prebuildify.

This issue captures the work happening in that PR and links it to our Release Milestone 0.15 to make it visible.

Check out https://github.com/cdktf/node-pty-prebuilt-multiarch/pull/5 for a list of open tasks currently missing in that PR.

References

github-actions[bot] commented 1 year ago

I'm going to lock this issue because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.