fix(lib): Correct types for allowedAccountIds & forbiddenAccountIds in S3Backend

Booligoosh commented 4 months ago

Related issue

No related issue as it is only a simple 2-line change. Can create one if required.

Description

When providing these fields as a string rather than a list of strings, Terraform throws an error. This PR updates the types to be a list of strings, to allow specifying the format that Terraform requires (similar to the other S3BackendConfig keys such as sharedConfigFiles, sharedCredentialsFiles etc).

Checklist

[x] I have updated the PR title to match CDKTF's style guide
[x] I have run the linter on my code locally
[x] I have performed a self-review of my code
[ ] ~I have commented my code, particularly in hard-to-understand areas~
[ ] ~I have made corresponding changes to the documentation if applicable~
[x] My changes generate no new warnings
[ ] ~I have added tests that prove my fix is effective or that my feature works if applicable~
[x] New and existing unit tests pass locally with my changes

hashicorp-cla-app[bot] commented 4 months ago

All committers have signed the CLA.

Booligoosh commented 4 months ago

Thanks for merging!

github-actions[bot] commented 3 months ago

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

hashicorp / terraform-cdk