djakielski
commented
1 month ago I had this issue also with other ressorces. Seams like an common issue.
Closed djakielski closed 2 days ago
djakielski
commented
1 month ago I had this issue also with other ressorces. Seams like an common issue.
djakielski
commented
1 month ago I also detect that new resources within a custruct were completly ignored.
I add a dynomoDB table and it is missing in the synth stack result.
export class OrderReaderStepFunction extends Construct {
private readonly stepFunction: StepFunction;
private readonly stateDb: DynamodbTable;
constructor(scope: Construct, id: string, config : OrderReaderStepFunctionConfig) {
super(scope, id, );
const file = new TerraformAsset(this, `definition`, {
path: path.resolve(__dirname, '../step-functions/orderReader.asl.json'),
type: AssetType.FILE,
assetHash: Fn.filemd5(path.resolve(__dirname, '../step-functions/orderReader.json'))
});
this.stateDb = new DynamodbTable(scope, `state-db`, {
name: "order-reader",
hashKey: "jobId",
attribute: [{
name: "jobId",
type: "S"
}]
});
this.stepFunction = new StepFunction(this, "function", {
name: 'order-reader',
tracingEnabled: true,
definition: Fn.templatefile(file.path, {
emailExtractorArn: config.emailExtractorArn,
stateDbName: this.stateDb.name,
topicClassifierArn: config.topicClassifierArn,
}),
loggingConfiguration: {
level: 'ALL',
include_execution_data: true
},
....This construct is a part of the stack
class OrderReader extends TerraformStack {
constructor(scope: Construct, id: string) {
super(scope, id);
new AwsProvider(this, "aws");
...
//More construct opbjects
...
new OrderReaderStepFunction(this, `${id}-step-function`,{
emailExtractorArn: emailExtractor.getLambdaArn(),
triggerBucket: ses.getInboundS3Bucket(),
triggerBucketPath: ses.getInboundS3Path(),
topicClassifierArn: topicClassifier.getLambdaArn()
});
DanielMSchmidt
commented
1 month ago We had issues like this at some point in the past with Typescript when folks where using tsc instead of ts-node and their build step then did not compile the program again, therefore executing the old js code. Other than that, CDKTF has no access to the old value during synth. I would suggest removing the cdktf.out folder as a test, maybe cdktf failed to produce something new and threw an error?
Other than that I notice this.stateDb = new DynamodbTable(scope, "state-db", { is using scope instead of this, is that by accident?
djakielski
commented
1 month ago Hey @DanielMSchmidt sounds intresting. Did you mean the app command or in package.json? The DynamodbTable was just a test, to check if it makes any difference.
I remove cdktf.out folder for so many times without any results.
cdktf.json
{
"language": "typescript",
"app": "npx ts-node main.ts",
"projectId": "xxxxxxxxxxxx",
"sendCrashReports": "true",
"terraformProviders": [
{
"name": "netcupdns",
"source": "sveba/netcupdns",
"version": "~> 1.2"
},
{
"name": "counters",
"source" :"RutledgePaulV/counters",
"version": "~> 0.0.5"
}
],
"terraformModules": [
{
"name": "step-function",
"source": "cloudposse/step-functions/aws",
"version": "~> 0.2"
},
{
"name": "ses-domain",
"source": "cloudposse/ses/aws",
"version": "~> 0.25"
},
{
"name": "lambda-function",
"source": "cloudposse/lambda-function/aws",
"version": "~> 0.6"
},
{
"name": "event-bridge",
"source": "terraform-aws-modules/eventbridge/aws",
"version": "~> 3.10"
}
],
"context": {
}
}package.json
{
"name": "order-reader",
"version": "1.0.0",
"main": "main.js",
"types": "main.ts",
"license": "MPL-2.0",
"private": true,
"packageManager": "pnpm@9.0.2",
"scripts": {
"postinstall": "npx cdktf get",
"get": "npx cdktf get",
"plan": "pnpm run build && cdktf plan",
"deploy": "pnpm run build && cdktf deploy",
"build": "turbo run build",
"synth": "npx cdktf synth",
"compile": "tsc --pretty",
"watch": "tsc -w",
"test": "jest",
"test:watch": "jest --watch",
"upgrade": "pnpm i -w cdktf@latest cdktf-cli@latest",
"upgrade:next": "pnpm i -w cdktf@next cdktf-cli@next"
},
"engines": {
"node": ">=18.0"
},
"dependencies": {
"@cdktf/provider-aws": "19.33.0",
"asl-types": "^1.2.1",
"cdktf": "^0.20.9",
"constructs": "^10.3.0"
},
"devDependencies": {
"cdktf-cli": "^0.20.9",
"@types/jest": "^29.5.12",
"@types/node": "^22.5.1",
"jest": "^29.7.0",
"ts-jest": "^29.2.5",
"ts-node": "^10.9.2",
"turbo": "^2.1.3",
"typescript": "^5.5.4"
}
}I mean whatever gets executed, if you run cdktf synth that would be the app command
djakielski
commented
2 days ago Hey, I found the solution! I wrapped my CDKTF project in a Turbo repo, which also handles the build process for our Lambda functions. When I executed the build job, the Node.js build step within the CDKTF project ran as well. This caused outdated JavaScript files to be generated, and it appears that CDKTF prioritizes these JS files over the original TypeScript files.
The solution was to delete js files and disable build step in turbo.
Expected Behavior
I had an Lambda function from a generated module (https://github.com/cloudposse/terraform-aws-lambda-function) and change name of handler attribute from mail.handler to index.handler. I also add a Policy attachment. So it should change the handler property and create new policy.
Actual Behavior
No changes detected
When i run cdktf deploy or cdktf synth in cdk.tf.json will sill be the old value "mail.handler". Also when I delete cdktf.out folder. I had no idea where the old value comes from. Maybe from remote backend?
Changes on Environment Variables are detected and will deployed.
Steps to Reproduce
Versions
language: typescript cdktf-cli: 0.20.8 node: v20.15.1 cdktf: 0.20.8 constructs: 10.3.0 jsii: null terraform: 1.7.2 arch: arm64 os: darwin 23.6.0 providers sveba/netcupdns@~> 1.2 (LOCAL) terraform provider version: 1.2.0 @cdktf/provider-aws (PREBUILT) terraform provider version: 5.65.0 prebuilt provider version: 19.33.0 cdktf version: ^0.20.0
Providers
┌─────────────────┬──────────────────┬─────────┬────────────┬─────────────────────┬─────────────────┐ │ Provider Name │ Provider Version │ CDKTF │ Constraint │ Package Name │ Package Version │ ├─────────────────┼──────────────────┼─────────┼────────────┼─────────────────────┼─────────────────┤ │ sveba/netcupdns │ 1.2.0 │ │ ~> 1.2 │ │ │ ├─────────────────┼──────────────────┼─────────┼────────────┼─────────────────────┼─────────────────┤ │ aws │ 5.65.0 │ ^0.20.0 │ │ @cdktf/provider-aws │ 19.33.0 │ └─────────────────┴──────────────────┴─────────┴────────────┴─────────────────────┴─────────────────┘
Gist
No response
Possible Solutions
No response
Workarounds
No response
Anything Else?
No response
References
No response
Help Wanted
Community Note