Open Pale-whale opened 4 months ago
Hi @Pale-whale,
Thank you for your interest in contributing to this project. I am going to review this PR next week. In the meantime, could you please sign the CLA(Contributor License Agreement) that is pending?
Thanks!
Hi @Pale-whale,
Thank you again for your contribution, there are a few things that I would like to ask you to add here and we should be good to go.
affinity
and tolerations
to the root values level, as it is done with imagePullSecrets
and replicaCount
. Those are the 'global' options whereas those that go under the operator
are either container or binary-specific.affinity
and tolerations
to the values.yaml
file with their default values, for example,affinity: {}
.affinity
and tolerations
. Let's keep the usage example away from the description and make it go first. We use helm-docs to generate Helm chart readme file, so an example would be the following:
# Usage example:
# affinity:
# nodeAffinity:
# requiredDuringSchedulingIgnoredDuringExecution:
# nodeSelectorTerms:
# - matchExpressions:
# - key: kubernetes.io/arch
# operator: In
# values:
# - amd64
#
# -- Kubernetes Affinity.
# More information: https://kubernetes.io/docs/concepts/scheduling-eviction/assign-pod-node/#affinity-and-anti-affinity
make helm-docs
and a new readme file will be generated.$ changie new --kind ENHANCEMENTS --custom "PR=350" --body '`Helm Chart`: Add new attributes `affinity` and `tolerations` to specify how operator pods should be scheduled on nodes in a cluster.'
Thank you!
Hi @arybolovlev,
Thanks for the insights, let me know if anything else is needed.
Thank you 😃
Hi @Pale-whale,
Please let me know if you can make the requested changes.
Thanks.
Description
This pr adds the ability to modify the affinity and tolerations of the operator
Usage Example
References
Community Note