search

hashicorp / terraform-config-inspect

A helper library for shallow inspection of Terraform configurations
Mozilla Public License 2.0
383 stars 76 forks source link

Fix CI failures #69

Closed alisdair closed 2 years ago

alisdair commented 2 years ago

Something is causing CI failures with the 1.11.13 build during go mod download. I've tried upgrading the CircleCI orb, and switching to an explicit circleci/go Docker image, and neither works.

This PR now also drops the 1.11.13 build and replaces it with a (current) 1.17.3. I can't see any reason why we're required to maintain compatibility with Go 1.11 indefinitely, so I believe this change is reasonable.

jbardin commented 2 years ago

Do we want to keep the go1.13 in there as well? That has also been unsupported for over a year.

I think we may want to update these to the hashi mirror as well: docker.mirror.hashicorp.services/cimg/go:1.17

jbardin commented 2 years ago

(also, pinning the minor release always gets the latest patch, which should be OK since this isn't pinned to a specific .go-version like other CLI tools)

alisdair commented 2 years ago

Fair points! Sorry I merged just before you hit send.

I made an attempt at those changes, but hit a new mysterious failure. I'm stepping back from this for now to move onto something else, but if you feel like digging in I'd be happy to review.