hashicorp / terraform-docs-agents

Content for Terraform's agents documentation.
terraform-docs-agents.vercel.app
Mozilla Public License 2.0
7 stars 15 forks source link

Update changelog.mdx #34

Closed zisom-hc closed 1 year ago

zisom-hc commented 1 year ago

Why

Fix a typo with the release date of 1.4.0

What

Before: 05/10/2022 After: 10/05/2022


Merge Checklist

If items do not apply to your changes, add (N/A) and mark them as complete.

Pull Request

Content

Reviews

vercel[bot] commented 1 year ago

@zisom-hc is attempting to deploy a commit to the HashiCorp Team on Vercel.

A member of the Team first needs to authorize it.

ryanuber commented 1 year ago

Woops! That definitely looks wrong. FYI this is generated by the tfc-agent repo's CHANGELOG, so if we only fix it here it will get overwritten on the next release. I'd recommend updating it there first, then we can merge this.

ryanuber commented 1 year ago

Also in case you are curious: you can see the usual flow of how this is updated in the RELEASING.md guide:

Generate a pull request to update the agent's changelog on the public website. You can do this by running the make changelog_website command from the root of this repository. You will see the updates get pushed to a new branch. Make sure you open the PR - this final step is not automatic.

zisom-hc commented 1 year ago

Good to know how this works; thanks for the insight. Turns out i don't have permissions to edit, create a branch, or fork the repo within the tfc-agent repo :sadpanda:. Would you be able to grant permissions, or make the change on my behalf?

image image

ryanuber commented 1 year ago

I just opened up the permissions such that you should have write access, which should allow you to make branches and push code to them. In theory that should allow the UI-based editing to work. Can you give that a rip?

zisom-hc commented 1 year ago

Thanks for opening up the permissions for me. I see that Natalie already took care of the typo within the changelog for the sake of the 1.6.0 release, so i'll go ahead and close this out, but will create a proper PR within the tfc-agent repo in the future