Kubernetes users are typically going to be more comfortable with a YAML format for pod specs, so this change modifies the usage of the agentWorkerPodTemplate to convert the YAML to JSON (before it finally gets expanded to base64 for the environment variable) using Helm's mustToJSON function. Because the value is taken to JSON whitespace is minified by the JSON converter and the final base64 encoding of the environment variable preserves any whitespace.
This can be tested and validated with helm template tfe . | grep TFE_RUN_PIPELINE_KUBERNETES_POD_TEMPLATE | awk '{print $2}' | base64 -d with the values.yaml's agentWorkerPodTemplate modified .
This PR also links to the pod spec docs in the values.yaml comment as well as the documentation.
Kubernetes users are typically going to be more comfortable with a YAML format for pod specs, so this change modifies the usage of the
agentWorkerPodTemplateto convert the YAML to JSON (before it finally gets expanded to base64 for the environment variable) using Helm'smustToJSONfunction. Because the value is taken to JSON whitespace is minified by the JSON converter and the final base64 encoding of the environment variable preserves any whitespace.This can be tested and validated with
helm template tfe . | grep TFE_RUN_PIPELINE_KUBERNETES_POD_TEMPLATE | awk '{print $2}' | base64 -dwith thevalues.yaml'sagentWorkerPodTemplatemodified .This PR also links to the pod spec docs in the
values.yamlcomment as well as the documentation.