search

hashicorp / terraform-enterprise-helm

The official repo for Terraform Enterprise helm charts
Mozilla Public License 2.0
16 stars 17 forks source link

deployment: use overridden service account name if specified #93

Closed USA-RedDragon closed 2 days ago

USA-RedDragon commented 1 week ago

Prior to this patch, if a serviceAccount.name is specified, the deployment would always use the namespace name as the name.

After this patch, the serviceAccountName will check for a custom value before defaulting to the namespace

Related: https://github.com/hashicorp/terraform-enterprise-helm/pull/91

USA-RedDragon commented 6 days ago

@jkerry @miguelhrocha could this get your attention? PR #91 was missing this change, causing anyone trying to use serviceAccount.name to have issues as the TFE pod's serviceAccountName is hard-coded.

nikolasrieble commented 2 days ago

As this is a bug fix and we are preparing a release, lets land this. The suggested change is functionally equivalent.