General Improvements - Githubissues

hashicorp / terraform-google-consul

A Terraform Module for how to run Consul on Google Cloud using Terraform and Packer

Apache License 2.0

94 stars 90 forks source link

Closed josh-padnick closed 6 years ago

josh-padnick commented 6 years ago

This PR:

Cleans up the help text of run-consul.
Replaces generic bash functions in our scripts with bash functions backed by automated tests from the Gruntwork Bash Commons repo
Improves error messages in the helper script in case users attempt to execute the helper script in a directory other than the one from which they ran terraform apply.
Fixes #14.
Sets Consul 1.1.0 as the default Consul version in the Packer template example.

josh-padnick commented 6 years ago

Alright, this module is finally updated to reflect all the latest best practices (other than #16). Merging now, but feedback welcome.