hashicorp / terraform-google-consul

A Terraform Module for how to run Consul on Google Cloud using Terraform and Packer
Apache License 2.0
94 stars 90 forks source link

fix(run-consul): datacenter param in consul config #20

Closed darkslategrey closed 6 years ago

darkslategrey commented 6 years ago

Datacenter will be for example 'europe-west1' instead of 'europe-west1-b'

dagoaty commented 6 years ago

Might be better to rename the function to get_instance_region as that's what's being returned now.

josh-padnick commented 6 years ago

Thanks for this PR! As I mentioned in https://github.com/hashicorp/terraform-google-consul/issues/19#issuecomment-418558720, this change will work for both single-zone and multi-zonal Instance Groups, so it LGTM and I'll merge now!

Fixes #19.