fix terraform attribute name

hashicorp / terraform-google-consul

A Terraform Module for how to run Consul on Google Cloud using Terraform and Packer

Apache License 2.0

94 stars 90 forks source link

fix terraform attribute name #32

Closed madsonic closed 6 years ago

madsonic commented 6 years ago

the attribute set in terraform is actually gcp_region

josh-padnick commented 6 years ago

Thanks for this fix! You're correct that we blindly renamed a var without updating the rest of the corresponding code, however it looks like there's actually more to update here:

This line should be updated to filter the Compute Instances by region instead of zone.
This line should be updated to rename the var to gcp_region, and we should update the other instances of this var accordingly.

Do you want to try your hand at making these updates?

madsonic commented 6 years ago

ah yes. pardon my oversight as well.

josh-padnick commented 6 years ago

Would you mind fixing the lingering issues so we can merge this PR?

madsonic commented 6 years ago

Sorry I took awhile. Fixed those spots as highlighted.

josh-padnick commented 6 years ago

LGTM!