search

hashicorp / terraform-google-consul

A Terraform Module for how to run Consul on Google Cloud using Terraform and Packer
Apache License 2.0
94 stars 90 forks source link

Adding region to templates if subnet is defined as well as modiifying… #38

Closed sharkannon closed 4 years ago

sharkannon commented 5 years ago

… to allow to override datacenter na

mes

hashicorp-cla commented 5 years ago

CLA assistant check
All committers have signed the CLA.

sharkannon commented 5 years ago

Little clarification on to this PR:

  1. If you don't define the region in the template, when using a Custom Subnet, you get errors that it can't find the subnet.
  2. Allowing the ability to override the name of the datacenter, so if you have multiple projects linked together on the same region and using DNS, you need to be able to distinguish the different projects.
sharkannon commented 5 years ago

I tested it using custom subnets while creating a project. I haven’t tested it using basic subnets. As for the datacentre part.. same thing, just tweaks I made while setting up my own multi region cluster.

robmorgan commented 4 years ago

Closing this for now due to the time and as I added support for a datacenter variable in https://github.com/hashicorp/terraform-google-consul/pull/55, however feel free to reopen if you still need the other functionality in this PR.