search

hashicorp / terraform-google-consul

A Terraform Module for how to run Consul on Google Cloud using Terraform and Packer
Apache License 2.0
94 stars 90 forks source link

Add app version for GC Region Instance Group Manager #49

Closed naiduarvind closed 4 years ago

naiduarvind commented 4 years ago

Signed-off-by: naiduarvind arvind.naidu@mindvalley.com

Screenshot 2019-11-26 at 5 55 30 PM

Without the version attribute present, terraform plan was not working as expected when deploying Vault referencing this module for Consul. Having this attribute for Vault fixed it hence creating this PR to ensure consistency for Consul - being the dependency module.

hashicorp-cla commented 4 years ago

CLA assistant check
All committers have signed the CLA.

naiduarvind commented 4 years ago

@josh-padnick @robmorgan - let's have this reviewed quickly and merged since it is quite simple a one-liner change.

naiduarvind commented 4 years ago

@josh-padnick @robmorgan what is status on reviewing this pull request?

tomstockton commented 4 years ago

The nomad module has the same issue. PR outstanding and un-merged / unloved.

arvindamirtaa commented 4 years ago

Any reason/blocker this hasn't been merged yet? Seems like a simple enough change that doesn't appear to break anything else.

robmorgan commented 4 years ago

Closing this PR in favor of https://github.com/hashicorp/terraform-google-consul/pull/55. We are going to take advantage of TF 0.12 and no longer use the template_file workaround.