search

hashicorp / terraform-google-consul

A Terraform Module for how to run Consul on Google Cloud using Terraform and Packer
Apache License 2.0
94 stars 90 forks source link

Fix output warnings from optional resources #6

Closed oralordos closed 6 years ago

oralordos commented 6 years ago

Fixes the warnings from Terraform about splat syntax requirements.

dalekurt commented 6 years ago

Thanks for the fix, I had logged an issue on this yesterday.

blaisep commented 6 years ago

@Oralordos I wonder if we should do something about the original mis-spelling of inbound ? The API seems to indicate that it is called allow_inboud_http_api

dalekurt commented 6 years ago

@blaisep Use version 0.10.8 there is an issue with 0.11.x and backward compatibility

josh-padnick commented 6 years ago

@Oralordos Thank you for submitting this fix! It looks fine, but since this is an official HashiCorp repo, i wanted to abide by the official Terraform 11 convention for Referencing Attributes from Resources with Count = 0. I've implemented that in #12.

Also, thank you to @blaisep for the typo call-out. I've fixed that in #13. Therefore, I'm going to close this PR and not merge.