search

hashicorp / terraform-google-vault

A Terraform Module for how to run Vault on Google Cloud using Terraform and Packer
Apache License 2.0
113 stars 75 forks source link

Fix #14 HA config cluster_addr and api_addr #17

Closed madmod closed 6 years ago

madmod commented 6 years ago

This PR implements the same changes as this PR in terraform-aws-vault which addresses hashicorp/vault#4383. This also fixes #14.

I have tested this change and it fixes the issue.

A future PR should also merge in this PR from terraform-aws-vault which allows for a custom API address in order to support HA client redirection with Vault behind a load balancer.

(Sorry for all of the whitespace changes my editor made. If thats an issue I can fix them. We might want to add an editorconfig.org file to this project so that contributors can follow the same style guidelines.)

josh-padnick commented 6 years ago

Thank you for this PR! I ran into this issue myself. I just manually validated correctness so merging now.