hashicorp / terraform-google-vault

A Terraform Module for how to run Vault on Google Cloud using Terraform and Packer
Apache License 2.0
113 stars 75 forks source link

Fix 404s. Make Load Balancer CIDR Block ranges specifiable. #23

Closed josh-padnick closed 6 years ago

josh-padnick commented 6 years ago

This PR fixes a few lingering broken links. In addition, it implements some trivial changes requested by @bgt101.

'cc @infosecgithub

bgt101 commented 6 years ago

Thanks @josh-padnick for making these changes. Currently those root_volume_disk_size_gb and root_volume_disk_type parameters are only used by vault_public in modules/vault-cluster/main.tf in the disk block:

  disk {
    boot         = true
    auto_delete  = true
    source_image = "${var.source_image}"
    disk_size_gb = "${var.root_volume_disk_size_gb}"
    disk_type    = "${var.root_volume_disk_type}"
  }

but they are missing from vault_private around line 117:

  disk {
    boot         = true
    auto_delete  = true
    source_image = "${var.source_image}"
  }

There's a similar omission in terraform-google-consul too in the modules/consul-cluster/main.tf file around line 116.

josh-padnick commented 6 years ago

Ah, I thought I was missing something. Thanks for clarifying. Just fixed in 63fa059!