search

hashicorp / terraform-google-vault

A Terraform Module for how to run Vault on Google Cloud using Terraform and Packer
Apache License 2.0
113 stars 75 forks source link

GCS bucket name #39

Closed Eoino closed 5 years ago

Eoino commented 5 years ago

There a reason that the cluster_name variable is used in favour of the aptly named gcs_bucket_name one? https://github.com/hashicorp/terraform-google-vault/blob/70e8e8d8b6ca66e4dfe2ab875afa73de33955062/modules/vault-cluster/main.tf#L278

robmorgan commented 5 years ago

Hi @Eoino, it was likely just a typo. I'll make a small PR and see if the tests pass. gcs_bucket_name is a required parameter so users should be passing it in correctly.

robmorgan commented 5 years ago

@Etiene you might need to see if my PR passes the tests and then merge it if possible?

sosimon commented 5 years ago

https://github.com/hashicorp/terraform-google-vault/blob/master/modules/vault-cluster/main.tf#L299 and https://github.com/hashicorp/terraform-google-vault/blob/master/modules/vault-cluster/main.tf#L312 should be fixed too I think.

sosimon commented 5 years ago

Sorry, has already been addressed in PR :)

robmorgan commented 5 years ago

@sosimon I'll make a release today.