search

hashicorp / terraform-google-vault

A Terraform Module for how to run Vault on Google Cloud using Terraform and Packer
Apache License 2.0
113 stars 75 forks source link

Update the script for google provider 2.0.0 #58

Closed anonyknight closed 3 years ago

anonyknight commented 3 years ago

Using the latest google provider 3.54.0 will have the following errors:

Error: Unsupported argument

on .terraform/modules/vault_cluster/modules/vault-cluster/main.tf line 60, in resource "google_compute_region_instance_group_manager" "vault": 60: instance_template = data.template_file.compute_instance_template_self_link.rendered

An argument named "instance_template" is not expected here.

Error: Unsupported argument

on .terraform/modules/vault_cluster/modules/vault-cluster/main.tf line 66, in resource "google_compute_region_instance_group_manager" "vault": 66: update_strategy = var.instance_group_update_strategy

An argument named "update_strategy" is not expected here.

update_strategy was documented in https://registry.terraform.io/providers/hashicorp/google/latest/docs/guides/version_2_upgrade

hashicorp-cla commented 3 years ago

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

Have you signed the CLA already but the status is still pending? Recheck it.

robmorgan commented 3 years ago

@anonyknight thanks for your contribution! This PR includes some of the same functionality we are hoping to introduce in https://github.com/hashicorp/terraform-google-vault/pull/55, however the problem we are facing is that for some reason Vault is unable to discover other nodes in the cluster likely due to a Consul DNS issue. As #55 includes a lot more additional functionality I'll close this PR, however feel free to test #55, see if it works for you and optionally submit any necessary fixes. Thanks!