Update main example for compatibility with Terraform 0.11

hashicorp / terraform-google-vault

A Terraform Module for how to run Vault on Google Cloud using Terraform and Packer

Apache License 2.0

115 stars 75 forks source link

Update main example for compatibility with Terraform 0.11 #7

Closed josh-padnick closed 6 years ago

josh-padnick commented 6 years ago

This is a demonstration of a fix in reference to #6, however I'd like to hold off on applying this change across the entire repo or merging this until the discussion at https://github.com/hashicorp/terraform/issues/16726 is resolved.

miles- commented 6 years ago

@josh-padnick we are running into this issue using master. Looks like https://github.com/hashicorp/terraform/issues/16726 is closed now. Should this PR be merged now?

josh-padnick commented 6 years ago

@miles- My apologies for the delayed response. We recently made the decision to allocate time to respond in a timely manner to the Gruntwork-managed GCP modules. In any case, to your point, yes, we're ready to merge this, and I'll do so now.