search

hashicorp / terraform-google-vault

A Terraform Module for how to run Vault on Google Cloud using Terraform and Packer
Apache License 2.0
115 stars 75 forks source link

Remove nginx dependency #9

Closed madmod closed 6 years ago

madmod commented 6 years ago

GCP now supports HTTPS health checks so nginx is no longer needed. (See GCE release notes August 04, 2017) I am willing to create a PR for this, but I would like someone to confirm that I'm not missing something.

josh-padnick commented 6 years ago

First, apologies for the delay responding on this. It appears you're correct! The limitation at the time we wrote this module wasn't the Google API support, it seems, but the Terraform provider support. However, it looks like Terraform's Google Provider now supports a compute_https_health_check. A PR to remove Nginx and use the HTTPS health check would be most welcome!

madmod commented 6 years ago

@josh-padnick I have implemented this enhancement in PR #16. It is a pretty big set of changes so I'd welcome another pair of eyes on it.

josh-padnick commented 6 years ago

Closing this issue due to #https://github.com/hashicorp/terraform-google-vault/pull/16#issuecomment-413720477. We're happy to reopen this if someone can show a working example.