Strings should not contain quotes in outputs

hashicorp / terraform-k8s

Terraform Cloud Operator for Kubernetes

https://learn.hashicorp.com/tutorials/terraform/kubernetes-operator?in=terraform/kubernetes

Mozilla Public License 2.0

455 stars 71 forks source link

Strings should not contain quotes in outputs #147

Closed ernadh closed 1 year ago

ernadh commented 2 years ago

TFE/Cloud output of type string does not contain quotes in TF state. Operator adds quotes which causes unexpected behavior to consumers in Kubernetes who should be receiving the same value as it is in the workspace.

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates or Closes #40

Release note for CHANGELOG:

hashicorp-cla commented 2 years ago

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

Ernad Halilovic seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you already have a GitHub account, please add the email address used for this commit to your account.

_{Have you signed the CLA already but the status is still pending? Recheck it.}

kferrone commented 2 years ago

I can confirm this is an issue. Can this be synced with the main branch and merged?

arybolovlev commented 1 year ago

Hi @ernadh,

I will go ahead and close it since this issue is fixed in https://github.com/hashicorp/terraform-k8s/pull/151.

Have a great week ahead!