hashicorp / terraform-k8s

Terraform Cloud Operator for Kubernetes
https://learn.hashicorp.com/tutorials/terraform/kubernetes-operator?in=terraform/kubernetes
Mozilla Public License 2.0
454 stars 71 forks source link

Can not update sensitive variables if non sensitive variables don't have any change #161

Open yqxiaxia opened 1 year ago

yqxiaxia commented 1 year ago

Community Note

terraform-k8s & Kubernetes Version

Affected Resource(s)

Terraform Configuration Files

# Copy-paste your Terraform configuration from the operator here.
# To retrieve the configuration, use `kubectl -n $NAMESPACE describe configmap $WORKSPACE_NAME`

Debug Output

Expected Behavior

Always update sensitive variables before a Run. Applying a workspace with sensitive or nonsensitive variable change, the workspace update should always be triggered

Actual Behavior

Hi team, I applied workspace with sensitive variable change, but no nonsensitive variable changes. And then it would not trigger workspace update.

Check the code here: https://github.com/hashicorp/terraform-k8s/blob/main/workspacehelper/tfc_variable.go#L135 it shows if there is no nonsensitive variable change, will skip the sensitive variables change.

why should do this?

Steps to Reproduce

Important Factoids

References

yqxiaxia commented 1 year ago

Hi here, any idea about this issue?