hashicorp / terraform-ls

Terraform Language Server
Mozilla Public License 2.0
996 stars 131 forks source link

Module Variable Intellisense does not work on registry submodules #1102

Closed JustinGrote closed 1 year ago

JustinGrote commented 2 years ago

Type: Bug

image

Works fine with non-submodules (per original feature PR example) image

Extension version: 2.24.3 VS Code version: Code - Insiders 1.73.0-insider (c3eebaead9d3bf1cb961b91fca1b8af31990d328, 2022-10-26T09:31:30.519Z) OS version: Windows_NT x64 10.0.19044 Modes: Sandboxed: Yes

System Info |Item|Value| |---|---| |CPUs|11th Gen Intel(R) Core(TM) i7-1185G7 @ 3.00GHz (8 x 2995)| |GPU Status|2d_canvas: enabled
canvas_oop_rasterization: disabled_off
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
skia_renderer: enabled_on
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
webgpu: disabled_off| |Load (avg)|undefined| |Memory (System)|15.69GB (2.62GB free)| |Process Argv|--crash-reporter-id f92bfe6d-d926-430e-8c73-f9d1695af3c8| |Screen Reader|no| |VM|0%|
A/B Experiments ``` vsliv695:30137379 vsins829:30139715 vsliv368:30146709 vsreu685:30147344 python383:30185418 vspor879:30202332 vspor708:30202333 vspor363:30204092 vslsvsres303:30308271 pythonvspyl392:30422396 pythontb:30258533 pythonptprofiler:30281269 vsdfh931:30280409 vshan820:30294714 pythondataviewer:30285072 vscod805:30301674 bridge0708:30335490 bridge0723:30353136 cmake_vspar411:30581797 vsaa593cf:30376535 pythonvs932:30404738 cppdebug:30492333 vscaac:30438845 vsclangdf:30492506 c4g48928:30535728 dsvsc012:30540252 pylantcb52:30590116 pyind367:30587847 vsccc:30564266 pyindex848:30577858 nodejswelcome1:30587009 gswce2:30598411 j6j51389:30596843 ```
radeksimko commented 2 years ago

Reproduced the bug, thank you for the report.

Attaching plaintext config for posterity:

module "palofw_vm" {
  source = "PaloAltoNetworks/vmseries-modules/azurerm/modules/vmseries"

}

Since all the functionality responsible for the module IntelliSense is provided by the language server I moved the issue here under terraform-ls repository.

smaftoul commented 1 year ago

Is this a duplicate of #1035 ? Any hint as if this would be easy to implement ?

radeksimko commented 1 year ago

@smaftoul Good catch, this is indeed a duplicate.

We can discuss implementation as part of #1035

github-actions[bot] commented 1 year ago

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.