Account for module calls pointing outside of the workspace

hashicorp / terraform-ls

Terraform Language Server

Mozilla Public License 2.0

997 stars 132 forks source link

Open dbanck opened 2 years ago

dbanck commented 2 years ago

Account for module calls pointing outside of the workspace which cannot be indexed via the walker and for any outdated installed modules.

[ ] Range over Declared module calls in indexer and index any modules which are unknown
[ ] Register any paths which are outside of the workspace for watching

Ensure this is reflected in all contexts - walker, watch events, didOpen/didChange, didChangeWorkspaceFolders.

radeksimko commented 2 years ago

After internal discussion we decided to put this on hold for now.

One concern was that we would not receive watch events for these modules outside the workspace and we aren't able to watch them until the (gopls) LSP structs bring the following: https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#relativePattern