search

hashicorp / terraform-plugin-codegen-openapi

OpenAPI to Terraform Provider Code Generation Specification
Mozilla Public License 2.0
50 stars 9 forks source link

Override schema `Description` with `param.Description` when available #14

Closed austinvalle closed 1 year ago

austinvalle commented 1 year ago

Closes #13

I'm not a huge fan of the SchemaOpts + GlobalSchemaOpts solution, but I'm punting (again 🦶🏻🏈) refactoring customization/configuration until we start working on custom annotations as that is the largest piece of customization that is known 👍🏻. I feel like the bounds of the problem are becoming better defined and that should continue when working on custom annotations.

Here is the failing test before regenerating the testdata: https://github.com/hashicorp/terraform-plugin-codegen-openapi/actions/runs/5224641257/jobs/9433086088?pr=14

I also added a command to regenerate the testdata generated IR 👍🏻

Some demo diffs as well!

Resource

image

Data Source

image

github-actions[bot] commented 3 months ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.