hashicorp / terraform-plugin-codegen-openapi

OpenAPI to Terraform Provider Code Generation Specification
Mozilla Public License 2.0
50 stars 9 forks source link

Update `codegen-spec` pkg and add a new edge case OAS #24

Closed austinvalle closed 1 year ago

austinvalle commented 1 year ago

Exact diff after upgrading the package and running make testdata

93a7733c2ee501dc2999eab59d6ee995fabbd6b7

Test failure after updating codegen-spec pkg with binary compare

=== CONT  TestGenerate_WithConfig/Scaleway_-_Instance_API
    /Users/austin.valle/code/terraform-plugin-codegen-openapi/internal/cmd/generate_test.go:67: unexpected difference:   bytes.Join({
                ... // 10 identical lines
                `                                                       "element_type": {`,
                `                                                               "list": {`,
        -       `                                                                       "element_type": {`,
        -       `                                                                               "string": {}`,
        -       `                                                                       }`,
        +       `                                                                       "string": {}`,
                `                                                               }`,
                `                                                       },`,
                ... // 12 identical lines
          }, "\n")
github-actions[bot] commented 3 months ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.