search

hashicorp / terraform-plugin-codegen-openapi

OpenAPI to Terraform Provider Code Generation Specification
Mozilla Public License 2.0
49 stars 9 forks source link

Initial support for enum property validations #29

Closed bflad closed 1 year ago

bflad commented 1 year ago

Closes #18

If the OpenAPI specification declares the enum property and the attribute is determined to be configurable, adds the validator to the specification output.

bflad commented 1 year ago

Can/should we implement similar mappings for Float64Attribute and NumberAttribute enum validators?

Probably. 😄 Will update.

EDIT: I'm not sure about NumberAttribute as the representation in OAS and the specification JSON might get funky.

Should we write a blurb about this mapping in the DESIGN.md?

If that makes sense, sure. You'll note though that I'm trying to create a lot of issues to achieve "full" parity where we can. At a certain point it might make more sense to say (or leave as open issues) what's not supported in JSON Schema/OAS. I guess we can cross that bridge when we get there though. I'll update the design doc.

github-actions[bot] commented 3 months ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.