search

hashicorp / terraform-plugin-codegen-openapi

OpenAPI to Terraform Provider Code Generation Specification
Mozilla Public License 2.0
49 stars 9 forks source link

Omit False Sensitive Properties from Specification #35

Closed bflad closed 1 year ago

bflad commented 1 year ago

Currently the specification from the pet store contains sensitive booleans that are false:

{
    "datasources": [
        {
            "name": "order",
            "schema": {
                "attributes": [
                    {
                        "name": "shipDate",
                        "string": {
                            "computed_optional_required": "computed_optional",
                            "description": "",
                            "sensitive": false
                        }
                    },
                    {
                        "name": "status",
                        "string": {
                            "computed_optional_required": "computed_optional",
                            "description": "Order Status",
                            "sensitive": false
                        }
                    }

These should be omitted as false matches the default behavior of the property in the specification and provides no value to the generated code.

github-actions[bot] commented 3 months ago

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.