search

hashicorp / terraform-plugin-codegen-openapi

OpenAPI to Terraform Provider Code Generation Specification
Mozilla Public License 2.0
49 stars 9 forks source link

Adjust Required and Default attributes to ComputedOptional #42

Closed bflad closed 1 year ago

bflad commented 1 year ago

Closes #38

This implements the typical provider development behavior of allowing a default value on an API required value to make its configuration optional. It is unclear if provider developers will need to adjust this behavior, but that can be sorted out in the future. Any API-intended behaviors that must be preserved will be surfaced via additional properties in the code generation specification to prevent conflating them with Terraform-intended behaviors.

bflad commented 1 year ago

Is https://github.com/hashicorp/terraform-plugin-codegen-openapi/pull/42/commits/f872133bd6e5e42a0e7b74fc34ba5de0612e8660 what you had in mind?

austinvalle commented 1 year ago

Is f872133 what you had in mind?

The wording looks good, but I don't think data sources needs the note 👍🏻

bflad commented 1 year ago

Doh right -- only resources 😅

github-actions[bot] commented 3 months ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.