Add <Type>Validators type and Equal() method

hashicorp / terraform-plugin-codegen-spec

Terraform Provider Code Generation Specification and Go Bindings

Mozilla Public License 2.0

7 stars 4 forks source link

Add <Type>Validators type and Equal() method #41

Closed bendbennett closed 12 months ago

bendbennett commented 12 months ago

References: #24

Currently, PR adds BoolValidators type and equality checking logic via BoolValidators.Equal() method.

Let me know if this looks agreeable, and I'll extend these changes to cover all Validators.

This will allow removal of equality checking logic from terraform-plugin-codegen-framework, for example, checking of validators equality.

bendbennett commented 12 months ago

Thanks for the review of the draft @austinvalle.

I've implemented the same logic and test coverage for:

Float64Validators
Int64Validators
ListValidators
MapValidators
NumberValidators
ObjectValidators
SetValidators
StringValidators

github-actions[bot] commented 3 months ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.