search

hashicorp / terraform-plugin-codegen-spec

Terraform Provider Code Generation Specification and Go Bindings
Mozilla Public License 2.0
7 stars 4 forks source link

embed ElementType for objects (to mirror maps, sets, and lists) #8

Closed austinvalle closed 1 year ago

austinvalle commented 1 year ago

I missed this in the original PR (apologies): https://github.com/hashicorp/terraform-plugin-codegen-spec/pull/1/files#diff-293e4410b228693685840b36ef3b6e9c99b50a6a37d8ae5b5d27cc150c139961, but I believe we landed that ObjectAttributeType would also embed similar to ListType, MapType and SetType

bflad commented 1 year ago

I'm a little worried that introducing this as "element" type might be confusing -- objects are attribute name to value type mappings, while element type is very explicitly the single value type terminology used by list/map/set collection types in Terraform.

austinvalle commented 1 year ago

Ah! That's fair. I initially thought it wasn't intentional. I'll move this back to draft and we can discuss more when I get back from vacay 👍🏻

github-actions[bot] commented 3 months ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.