hashicorp / terraform-plugin-sdk

Terraform Plugin SDK enables building plugins (providers) to manage any service providers or custom in-house solutions
https://developer.hashicorp.com/terraform/plugin
Mozilla Public License 2.0
439 stars 232 forks source link

fix: when parsing map length entries look for the key exactly equalling % #1369

Closed sbogacz closed 2 months ago

sbogacz commented 2 months ago

fix: when parsing map length entries look for the key exactly equalling % rather than being prefixed with it, to allow for map keys names to start with %.

When working with a custom provider I ran into an issue where map entries starting with % were being dropped, and not being passed to the provider implementation. I noticed that there were different approaches to checking for the map length, e.g. in internalconfigs/hcl2shim/flatmap.go:

https://github.com/hashicorp/terraform-plugin-sdk/blob/651ff3354401b964d3d3a9cd3d396afad121128c/internal/configs/hcl2shim/flatmap.go#L284

hashicorp-cla-app[bot] commented 2 months ago

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes


Steven Bogacz seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

Have you signed the CLA already but the status is still pending? Recheck it.