helper/resource: Fix panic in output state shimming when a tuple is present

hashicorp / terraform-plugin-testing

Module for testing Terraform providers

Mozilla Public License 2.0

44 stars 11 forks source link

helper/resource: Fix panic in output state shimming when a tuple is present #314

Closed austinvalle closed 3 months ago

austinvalle commented 3 months ago

Closes #310

austinvalle commented 3 months ago

If you wanted to update the unit testing for this, its awkwardly in helper/resource_testing_new_test.go file TestShimState. In particular it seems like the complex outputs case could use the additional tuple testing 👍

I completely missed this test lol. Great shout! Added three use-cases to this test to cover the old type assertions and now my test coverage says we're all covered (besides the default case 🙃) 🚀 1d5e473

github-actions[bot] commented 2 months ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.