search

hashicorp / terraform-provider-archive

Utility provider that provides a data source that can create zip archives for individual files or collections of files.
https://registry.terraform.io/providers/hashicorp/archive/latest/docs
Mozilla Public License 2.0
91 stars 63 forks source link

Add glob file pattern matching support for the `excludes` attribute. #354

Closed SBGoods closed 3 months ago

SBGoods commented 3 months ago

Resolves: #62 Closes: #57 Closes: #86 Closes: #98

Add glob file pattern matching to the excludes attributes for the archive_file data source and resource. Supports doublestar ** pattern matching with the bmatcuk/doublestar library.

jd-sandk commented 3 months ago

will this be in v2.4.3 and do we know when this will be released?

SBGoods commented 3 months ago

Hi @jd-sandk, this PR will be included in v2.5.0 which will be released tomorrow.

jd-sandk commented 3 months ago

[@SBGoods @austinvalle] Thank you Selena and Austin, and everyone else for their hard work. I ran across: https://github.com/hashicorp/terraform-provider-archive/issues/62 yesterday around 3PM EST, and looked at it as a bit hopeless as it had been open for a really long time. . . I think I left the page and then decided to circle back to add a simple 👍 vote for the issue, and after my browser loaded the page fresh about 5 minutes later, I was very astounded that the issue was now closed and mark completed.

I ran to this page and was very happy to see everything is solved in this PR, and extremely thankful in the timing of this PR, I've never bumped into an issue before and hoped for it to be resolved soon, and actually have that hope fulfilled. Even though this solution probably was in the pipeline and being worked for a long time: to me it felt like instant gratification.

So for that I just want to thank you all again! 🥳🎉