hashicorp / terraform-provider-aws

The AWS Provider enables Terraform to manage AWS resources.
https://registry.terraform.io/providers/hashicorp/aws
Mozilla Public License 2.0
9.81k stars 9.16k forks source link

Add support for AuthTokenUpdateStrategy to aws_elasticache_replication_group #11524

Closed karlismelderis closed 11 months ago

karlismelderis commented 4 years ago

Community Note

Description

Every time auth_token changes terraform is destroying Redis cluster. it should/could be possible to set new token without destroy if TF would use AuthTokenUpdateStrategy option.

New or Affected Resource(s)

Potential Terraform Configuration

resource "aws_elasticache_replication_group" "as_redis" {
  auth_token = "some_super_secret_new_token"
  auth_token_update_strategy = "<set|rotate>"
  engine = "redis"
  transit_encryption_enabled = true
  lifecycle {
    prevent_destroy = true
  }
}

References

christoph-h commented 3 years ago

There is an open PR, that should allow to update the auth token using the rotate strategy: https://github.com/hashicorp/terraform-provider-aws/pull/16203

hskrtich commented 2 years ago

The code for this request was merged last year, This issue can be closed.

Israphel commented 2 years ago

The code for this request was merged last year, This issue can be closed.

where? I don't see the feature https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/elasticache_replication_group#auth_token

hskrtich commented 2 years ago

@Israphel Here is the PR for it. https://github.com/hashicorp/terraform-provider-aws/pull/16203

This was added in version 3.67.0 (November 25, 2021)

Israphel commented 2 years ago

so, they didn't add the update strategy, they're allowing to change auth_token outside

hskrtich commented 2 years ago

ah sorry, I was confused with the description of this issue. The "Every time auth_token changes terraform is destroying Redis cluster." part is fixed. The "AuthTokenUpdateStrategy option" part is not implemented.

varkey commented 1 year ago

Adding support for AuthTokenUpdateStrategy will also help if one wants to migrate from Redis Auth to RBAC which would require the AuthTokenUpdateStrategy to be set to DELETE

https://docs.aws.amazon.com/AmazonElastiCache/latest/red-ug/Clusters.RBAC.html#Migrate-From-RBAC-to-Auth

github-actions[bot] commented 11 months ago

This functionality has been released in v5.27.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions[bot] commented 10 months ago

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.