Add support for setting awsVpcTrunking in aws_ecs_cluster resource

hashicorp / terraform-provider-aws

The AWS Provider enables Terraform to manage AWS resources.

https://registry.terraform.io/providers/hashicorp/aws

Mozilla Public License 2.0

9.8k stars 9.15k forks source link

Add support for setting awsVpcTrunking in aws_ecs_cluster resource #11988

Closed cutik closed 2 years ago

cutik commented 4 years ago

Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

AWS ECS cluster supports setting AWSVPC Trunking to increase number of ENIs for EC2 instances. However currently only setting for containerInsights is supported.

New or Affected Resource(s)

aws_ecs_cluster

Potential Terraform Configuration

resource "aws_ecs_cluster" "ecs_cluster" {
  name = var.cluster_name
  setting {
    name  = "awsvpcTrunking" # NOT IMPLEMENTED IN TERRAFORM YET
    value = "enabled"
  }
}

Actual behaviour:

Error: expected setting.0.name to be one of [containerInsights], got awsvpcTrunking

ewbankkit commented 4 years ago

Announcement. Blog post. Developer guide.

awsvpcTrunking is enabled via the ECS account settings. Related:

https://github.com/terraform-providers/terraform-provider-aws/issues/10168

adamhathcock commented 4 years ago

I'd like to support all values: https://docs.aws.amazon.com/AmazonECS/latest/APIReference/API_PutAccountSettingDefault.html

Not sure when these were added but they're the same: serviceLongArnFormat taskLongArnFormat containerInstanceLongArnFormat

d4nyll commented 4 years ago

github-actions[bot] commented 2 years ago

Marking this issue as stale due to inactivity. This helps our maintainers find and focus on the active issues. If this issue receives no comments in the next 30 days it will automatically be closed. Maintainers can also remove the stale label.

If this issue was automatically closed and you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thank you!

github-actions[bot] commented 2 years ago

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.