Implement aws_sns_topic Sweeper

[bflad]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

The acceptance testing can leave lingering resources on failed runs (e.g. via coding issues during development or panics). These lingering resources can cause quota limits to be reached, extraneous money to be spent, or in some worst cases leave open security risks in the testing account.

We do not require sweeper implementation during initial resource implementation at this time, but this may change in the future when the process can be simplified and documented better.

e.g. after many years of daily (or more) testing runs

$ aws sns list-topics | jq '.Topics | length'
155

This resource sweeper should have dependencies on upstream resources, e.g. (some sweepers may not be implemented)

• aws_autoscaling_notification
• aws_budgets_budget
• aws_config_delivery_channel
• aws_dax_cluster
• aws_db_event_subscription
• aws_elasticache_cluster
• aws_elasticache_replication_group
• aws_glacier_vault
• aws_neptune_event_subscription
• aws_redshift_event_subscription
• aws_s3_bucket_notification
• aws_ses_event_destination
• aws_ses_identity_notification
• aws_ses_receipt_rule
• aws_sns_platform_application

New or Affected Resource(s)

• aws_sns_topic

Definition of Done

• Sweeper implemented without errors
• Testing account empty of this resource:

$ aws sns list-topics | jq '.Topics | length'
0

[ewbankkit]

These upstream resources require sweepers added:

• [x] aws_budgets_budget - https://github.com/terraform-providers/terraform-provider-aws/pull/13210
• [x] aws_db_event_subscription - https://github.com/terraform-providers/terraform-provider-aws/pull/13213
• [x] aws_glacier_vault - https://github.com/terraform-providers/terraform-provider-aws/pull/13184
• [x] aws_iot_topic_rule - https://github.com/terraform-providers/terraform-provider-aws/pull/13245
• [x] aws_neptune_event_subscription - https://github.com/terraform-providers/terraform-provider-aws/pull/13214
• [x] aws_redshift_event_subscription - https://github.com/terraform-providers/terraform-provider-aws/pull/13215
• [x] aws_ses_configuration_set - https://github.com/terraform-providers/terraform-provider-aws/pull/13216
• [x] aws_ses_domain_identity - https://github.com/terraform-providers/terraform-provider-aws/pull/13217
• [x] aws_ses_email_identity - https://github.com/terraform-providers/terraform-provider-aws/pull/13217
• [x] aws_ses_receipt_rule_set - https://github.com/terraform-providers/terraform-provider-aws/pull/13169
• [x] aws_sns_platform_application - https://github.com/terraform-providers/terraform-provider-aws/pull/13168

Also aws_backup_vault_notifications added via https://github.com/terraform-providers/terraform-provider-aws/pull/12501.

[ewbankkit]

As a follow on, use the new internal waiters package added for aws_db_event_subscription etc. in the main resource code.

[ghost]

This has been released in version 2.62.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!