hashicorp / terraform-provider-aws

The AWS Provider enables Terraform to manage AWS resources.
https://registry.terraform.io/providers/hashicorp/aws
Mozilla Public License 2.0
9.81k stars 9.16k forks source link

aws_elasticache - add support for notification_topic_status #12919

Closed toredash closed 1 year ago

toredash commented 4 years ago

Community Note

Description

Currently the AWS provider does not support notification-topic-status, but it does support notification-topic-arn.

If a user manually disabled the topic arn from cli or AWS Console, terraform apply won't detect the change as the topic arn is defined, but is marked inactive in the API: image

Requesting that aws_elasticache_cluster and aws_elasticache_replication_group is expanded to support notification-topic-status. API from AWS already supports this

New or Affected Resource(s)

Potential Terraform Configuration

resource "aws_elasticache_cluster" "example" {
  cluster_id           = "cluster-example"
  engine               = "memcached"
  node_type            = "cache.m4.large"
  num_cache_nodes      = 2
  parameter_group_name = "default.memcached1.4"
  port                 = 11211
  notification_topic_arn = "arn:aws:sns:us-east-1:012345678999:my_sns_topic"
+  notification_topic_status = "active"

}

References

https://docs.aws.amazon.com/AmazonElastiCache/latest/APIReference/API_ModifyCacheCluster.html https://docs.aws.amazon.com/AmazonElastiCache/latest/APIReference/API_ModifyReplicationGroup.html

github-actions[bot] commented 1 year ago

Marking this issue as stale due to inactivity. This helps our maintainers find and focus on the active issues. If this issue receives no comments in the next 30 days it will automatically be closed. Maintainers can also remove the stale label.

If this issue was automatically closed and you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thank you!

github-actions[bot] commented 1 year ago

I'm going to lock this issue because it has been closed for 30 days ā³. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.