hashicorp / terraform-provider-aws

The AWS Provider enables Terraform to manage AWS resources.
https://registry.terraform.io/providers/hashicorp/aws
Mozilla Public License 2.0
9.82k stars 9.17k forks source link

`allow_major_version_upgrade` is missing from aws_dms_replication_instance #14438

Closed eoliphan closed 4 years ago

eoliphan commented 4 years ago

Community Note

Description

The AllowMajorVersionUpgrade flag is necessary to perform major updates to the aws_dms_replication_instance type

New or Affected Resource(s)

aws_dms_replication_instance

Potential Terraform Configuration

resource "aws_dms_replication_instance" "default" {
  allocated_storage            = var.allocated_storage
  apply_immediately            = true
  auto_minor_version_upgrade   = true
  engine_version               = var.engine_version
  allow_major_version_upgrade = true

References

bflad commented 4 years ago

Adding this functionality would also allow fixing the currently failing test:

=== CONT  TestAccAWSDmsReplicationInstance_EngineVersion
TestAccAWSDmsReplicationInstance_EngineVersion: testing.go:684: Step 1 error: errors during apply:
Error: error modifying DMS Replication Instance (tf-acc-test-1816079488213827146): InvalidParameterCombinationException: The AllowMajorVersionUpgrade flag must be present when upgrading to a new major version.
bflad commented 4 years ago

Support for this new argument has been merged and will release with version 3.3.0 of the Terraform AWS Provider, next week. Thanks to @shuheiktgw for the implementation. 👍

ghost commented 4 years ago

This has been released in version 3.3.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

ghost commented 4 years ago

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!