aws_mq_broker Using auto_minor_version_upgrade causes engine_version drift

dekimsey commented 4 years ago

Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

When using the auto_minor_version_upgrade, the engine_version parameter can drift (become out of date). This causes spurious plans where terraform wants to downgrade the engine. I propose when auto_minor_version_upgrade is set, the engine version be compared as a glob on the minor version.

Thus eliminating plan reports like such:

  # aws_mq_broker.amq must be replaced
-/+ resource "aws_mq_broker" "amq" {
        auto_minor_version_upgrade = true
      ~ engine_version             = "5.15.12" -> "5.15.10" # forces replacement
}

Perhaps instead, a new minimum_engine_version parameter should be set. Thus allowing AWS automatic upgrades to happen gracefully and not have terraform attempt to downgrade.

New or Affected Resource(s)

aws_mq_broker

Potential Terraform Configuration

resource "aws_mq_broker" "amq" {
  broker_name         = "amq"
  engine_type         = "ActiveMQ"
  minimum_engine_version      = "5.15.10"
  auto_minor_version_upgrade = true

Alternatively, re-interpret the existing parameter as a minimum if auto_minor_version_upgrade is set.

resource "aws_mq_broker" "amq" {
  broker_name         = "amq"
  engine_type         = "ActiveMQ"
  engine_version      = "5.15.10"  # minimum since auto_minor_version_upgrade is set
  auto_minor_version_upgrade = true

References

0000

jchristner-trustwave commented 4 years ago

Alternatively, it could be handled like the engine_version parameter in aws_db_instance where if auto_minor_version_upgrade is set, you can just provide a prefix of the version so "5.5" would work for all "5.5.x" versions.