hashicorp / terraform-provider-aws

The AWS Provider enables Terraform to manage AWS resources.
https://registry.terraform.io/providers/hashicorp/aws
Mozilla Public License 2.0
9.84k stars 9.19k forks source link

d/neptune_orderable_db_instance: Prioritize engine default version if none is given #15206

Closed YakDriver closed 4 years ago

YakDriver commented 4 years ago

Community Note

Description

Two proposals:

  1. Ease the practitioner burden of working across regions and partitions by prioritizing the default engine version when none is given. AWS defines a default version of engines, which may vary from region to region and partition to partition. This change also aligns this data source with other areas of AWS where the default version is used where none is provided (e.g., aws_rds_cluster). Not having to keep up with versions can make writing configurations easier and more maintainable.
  2. Since this data source only has only one engine, neptune, and one license model, amazon-license, these should be defaults so that it is unnecessary to include in configurations.

New or Affected Resource(s)

Potential Terraform Configuration

Before (would still be valid) - using engine_version:

data "aws_neptune_orderable_db_instance" "test" {
  engine                     = "neptune"
  engine_version             = "1.0.3.0"
  license_model              = "amazon-license"
  preferred_instance_classes = ["db.r6.xlarge", "db.m4.large", "db.t3.small"]
}

After:

data "aws_neptune_orderable_db_instance" "test" {
  preferred_instance_classes = ["db.r6.xlarge", "db.m4.large", "db.t3.small"]
}

References

ghost commented 4 years ago

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!