hashicorp / terraform-provider-aws

The AWS Provider enables Terraform to manage AWS resources.
https://registry.terraform.io/providers/hashicorp/aws
Mozilla Public License 2.0
9.82k stars 9.16k forks source link

New Resource: aws_timestreamwrite_table #15422

Closed yardensachs closed 3 years ago

yardensachs commented 4 years ago

Community Note

Description

Amazon Timestream is now generally available, and a supporting Terraform resource for managing a table is necessary. Amazon Timestream is a fast, scalable, fully managed, purpose-built time series database. (#15421 was created for aws_timestreamwrite_database)

New or Affected Resource(s)

Potential Terraform Configuration

resource "aws_timestreamwrite_table" "example" {
  database_name = aws_timestreamwrite_database.database_name
  table_name    = "string"
  retention_properties {
    magnetic_store_retention_period_in_days = 10
    memory_store_retention_period_in_hours  = 10
  }
  tags = {
    Name = "value"
  }
}

References

roberth-k commented 4 years ago

API documentation is part of the Developer Guide: https://docs.aws.amazon.com/timestream/latest/developerguide/API_Reference.html.

ewbankkit commented 4 years ago

Strictly, this resource should be named aws_timestreamwrite_table to match the AWS service name and the resource naming conventions. AWS call the underlying API the Timestream Write API.

yardensachs commented 4 years ago

@ewbankkit Updated

ewbankkit commented 4 years ago

Requires AWS SDK v1.34.34:

TomTucka commented 4 years ago

I started working on this, should have a PR open by tomorrow evening πŸ™‚

yardensachs commented 4 years ago

Hi @TomTucka thanks! I have a draft branch for tables waiting and ready actually, but I cant finish it before the team reviews #15463 Because you would need a database first anyway for testing

dusansusic commented 3 years ago

Is there any timeframe when this could to be merged?

ivanovit commented 3 years ago

Hi @yardensachs, Could you please share the draft branch for tables?

yardensachs commented 3 years ago

@ivanovit looks like I lost that branch for some reason, so I don't have that work anymore :(

anGie44 commented 3 years ago

Hi @yardensachs πŸ‘‹ Apologies for the wait here! Totally understand if its not the best time to pick up doing the implementation for this again, but if you are still interested, let us know πŸ˜„ We'll wait about a week to hear back, and then from there, I'm happy to continue the implementation.

ghost commented 3 years ago

This has been released in version 3.40.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

github-actions[bot] commented 3 years ago

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.