mattburgess
commented
1 year ago Given the advice at https://developer.hashicorp.com/terraform/tutorials/aws/aws-iam-policy?in=terraform%2Faws#refactor-your-policy, I'm wondering whether this ticket should skip the middle step of heredoc -> jsonencode() and instead convert all heredocs into aws_iam_policy_documents? I'm happy to tackle this one once we've reached agreement on approach.
Community Note
Description
Martin's excellent summary in https://github.com/hashicorp/terraform-provider-aws/pull/16792 explains this best:
This issue is for tracking and replacing other examples, but does not offer any initial future-proofing enforcement solutions.
Affected Files
Changes to these files should be submitted in batches, to prevent delayed reviews and merge conflicts.
website/docs/d/billing_service_account.html.markdownwebsite/docs/d/cloudtrail_service_account.html.markdownwebsite/docs/d/ecs_task_definition.html.markdownwebsite/docs/d/elb_service_account.html.markdownwebsite/docs/d/kms_ciphertext.html.markdownwebsite/docs/d/lambda_invocation.html.markdownwebsite/docs/d/redshift_service_account.html.markdownwebsite/docs/r/api_gateway_account.html.markdownwebsite/docs/r/api_gateway_authorizer.html.markdownwebsite/docs/r/api_gateway_integration.html.markdownwebsite/docs/r/api_gateway_integration_response.html.markdownwebsite/docs/r/api_gateway_model.html.markdownwebsite/docs/r/api_gateway_rest_api_policy.html.markdownwebsite/docs/r/apigatewayv2_model.html.markdownwebsite/docs/r/appsync_datasource.html.markdownwebsite/docs/r/appsync_function.html.markdownwebsite/docs/r/appsync_graphql_api.html.markdownwebsite/docs/r/appsync_resolver.html.markdownwebsite/docs/r/autoscaling_group.html.markdownwebsite/docs/r/autoscaling_lifecycle_hook.html.markdownwebsite/docs/r/backup_selection.html.markdownwebsite/docs/r/backup_vault_policy.html.markdownwebsite/docs/r/batch_compute_environment.html.markdownwebsite/docs/r/batch_job_definition.html.markdownwebsite/docs/r/cloudformation_stack.html.markdownwebsite/docs/r/cloudformation_stack_set.html.markdownwebsite/docs/r/cloudfront_realtime_log_config.html.markdownwebsite/docs/r/cloudtrail.html.markdownwebsite/docs/r/cloudwatch_composite_alarm.html.markdownwebsite/docs/r/cloudwatch_dashboard.html.markdownwebsite/docs/r/cloudwatch_event_archive.html.markdownwebsite/docs/r/cloudwatch_event_rule.html.markdownwebsite/docs/r/cloudwatch_event_target.html.markdownwebsite/docs/r/codeartifact_domain_permissions_policy.html.markdownwebsite/docs/r/codeartifact_repository_permissions_policy.html.markdownwebsite/docs/r/codebuild_project.html.markdownwebsite/docs/r/codebuild_report_group.html.markdownwebsite/docs/r/codedeploy_deployment_group.html.markdownwebsite/docs/r/codepipeline.markdownwebsite/docs/r/cognito_identity_pool_roles_attachment.markdownwebsite/docs/r/cognito_user_group.html.markdownwebsite/docs/r/cognito_user_pool_client.markdownwebsite/docs/r/config_config_rule.html.markdownwebsite/docs/r/config_configuration_aggregator.html.markdownwebsite/docs/r/config_configuration_recorder.html.markdownwebsite/docs/r/config_configuration_recorder_status.html.markdownwebsite/docs/r/config_conformance_pack.html.markdownwebsite/docs/r/config_delivery_channel.html.markdownwebsite/docs/r/dlm_lifecycle_policy.markdownwebsite/docs/r/dynamodb_table_item.html.markdownwebsite/docs/r/ecr_lifecycle_policy.html.markdownwebsite/docs/r/ecr_repository_policy.html.markdownwebsite/docs/r/ecs_task_definition.html.markdownwebsite/docs/r/efs_file_system_policy.html.markdownwebsite/docs/r/eks_cluster.html.markdownwebsite/docs/r/elasticsearch_domain.html.markdownwebsite/docs/r/elasticsearch_domain_policy.html.markdownwebsite/docs/r/emr_cluster.html.markdownwebsite/docs/r/emr_instance_group.html.markdownwebsite/docs/r/emr_security_configuration.html.markdownwebsite/docs/r/flow_log.html.markdownwebsite/docs/r/fms_policy.html.markdownwebsite/docs/r/glacier_vault.html.markdownwebsite/docs/r/glue_crawler.html.markdownwebsite/docs/r/iam_access_key.html.markdownwebsite/docs/r/iam_instance_profile.html.markdownwebsite/docs/r/iam_policy_attachment.html.markdownwebsite/docs/r/iam_role_policy_attachment.markdownwebsite/docs/r/iam_server_certificate.html.markdownwebsite/docs/r/iam_user.html.markdownwebsite/docs/r/iot_policy_attachment.html.markdownwebsite/docs/r/iot_role_alias.html.markdownwebsite/docs/r/iot_topic_rule.html.markdownwebsite/docs/r/kinesis_firehose_delivery_stream.html.markdownwebsite/docs/r/kms_ciphertext.html.markdownwebsite/docs/r/kms_grant.html.markdownwebsite/docs/r/lambda_function.html.markdownwebsite/docs/r/lambda_permission.html.markdownwebsite/docs/r/media_store_container_policy.html.markdownwebsite/docs/r/mq_configuration.html.markdownwebsite/docs/r/msk_cluster.html.markdownwebsite/docs/r/msk_configuration.html.markdownwebsite/docs/r/msk_scram_secret_association.html.markdownwebsite/docs/r/opsworks_stack.html.markdownwebsite/docs/r/organizations_policy.html.markdownwebsite/docs/r/pinpoint_email_channel.markdownwebsite/docs/r/pinpoint_event_stream.markdownwebsite/docs/r/resourcegroups_group.html.markdownwebsite/docs/r/s3_bucket.html.markdownwebsite/docs/r/s3_bucket_notification.html.markdownwebsite/docs/r/secretsmanager_secret_policy.html.markdownwebsite/docs/r/sfn_state_machine.html.markdownwebsite/docs/r/sns_topic.html.markdownwebsite/docs/r/sqs_queue_policy.html.markdownwebsite/docs/r/ssm_activation.html.markdownwebsite/docs/r/ssm_document.html.markdownwebsite/docs/r/ssm_patch_baseline.html.markdownwebsite/docs/r/ssm_resource_data_sync.html.markdownwebsite/docs/r/transfer_server.html.markdownwebsite/docs/r/transfer_ssh_key.html.markdownwebsite/docs/r/transfer_user.html.markdownwebsite/docs/r/vpc_endpoint_connection_notification.html.markdownwebsite/docs/r/xray_encryption_config.html.markdownReferences