resource/aws_elasticache_cluster: Add Outpost support

gdavison commented 3 years ago

Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Add Outpost support to aws_elasticache_cluster.

Potential Terraform Configuration

New fields:

resource "aws_elasticache_cluster" "example" {
  ...
  outpost_mode = "single-outpost" # Valid values: "single-outpost" and "cross-outpost"

  preferred_outpost_arn = "<valid ARN>"
}

Note: only single-outpost is currently supported.

Note: CreateCacheClusterInput has both a single PreferredOutpostArn and list PreferredOutpostArns, but CacheCluster only has the field PreferredOutpostArn and does not have the field OutpostMode.

Affected Resource

resource/aws_elasticache_cluster
data source/aws_elasticache_cluster

Potential Terraform Configuration

# Copy-paste your Terraform configurations here - for large Terraform configs,
# please use a service like Dropbox and share a link to the ZIP file. For
# security, you can also encrypt the files using our GPG public key.

References

ElastiCache for Redis: https://docs.aws.amazon.com/AmazonElastiCache/latest/red-ug/ElastiCache-Outposts.html
ElastiCache for Memcached: https://docs.aws.amazon.com/AmazonElastiCache/latest/mem-ug/ElastiCache-Outposts.html

weizhangfd commented 1 year ago

👋 @gdavison ~I have made a PR for this enhancement, but I don't seem to have push right to the repo. Would you mind giving me the write access please?~ 🙏

Edit: I have just learned from https://github.com/hashicorp/packer/blob/main/.github/CONTRIBUTING.md that I should do a fork and open PR from there. Apologies for the unnecessary push right request.

Edit: I have attempted to implement this enhancement at https://github.com/hashicorp/terraform-provider-aws/pull/27934. Please could you kindly review at your earliest convenience? I apologies for not being able to run the acceptance tests on outpost myself. Thank you for your help in advance.

github-actions[bot] commented 1 year ago

This functionality has been released in v4.41.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions[bot] commented 1 year ago

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

hashicorp / terraform-provider-aws