Replace or remove calls to `fmt.Print` (and variants)

[ewbankkit]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Random calls to fmt.Printf (and similar) in the code should be replaced with log.Printf or removed:

% find aws/ -name '*.go' -print | xargs grep 'fmt\.Print'
aws//internal/vault/sdk/helper/jsonutil/json_test.go:       fmt.Printf("decoding err: %v\n", err)
aws//resource_aws_api_gateway_rest_api.go:      fmt.Printf("error normalizing policy JSON: %s\n", err)
aws//resource_aws_lakeformation_permissions_test.go:            fmt.Print(out)
aws//resource_aws_lb_ssl_negotiation_policy_test.go:            fmt.Printf("[ERROR] Problem describing load balancer policy '%s': %s", policyName, err)
aws//resource_aws_cloudwatch_event_target_test.go:      fmt.Printf("%#v", rs.Primary.Attributes)
aws//resource_aws_sns_topic_subscription_test.go:       fmt.Println(err)

Consider adding a linter rule to prevent these in future.

[ewbankkit]

resource_aws_cloudwatch_event_target_test.go addressed in #18491.

[ghost]

This has been released in version 3.38.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[github-actions[bot]]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.