hashicorp / terraform-provider-aws

The AWS Provider enables Terraform to manage AWS resources.
https://registry.terraform.io/providers/hashicorp/aws
Mozilla Public License 2.0
9.8k stars 9.15k forks source link

Update Unit Testing for Rotated Keybase Key #19080

Closed bflad closed 3 years ago

bflad commented 3 years ago

Community Note

Description

As part of https://discuss.hashicorp.com/t/hcsec-2021-12-codecov-security-event-and-hashicorp-gpg-key-exposure/23512, the Keybase hashicorp keys were rotated. Some testing was relying on the previous fingerprints, which can be seen with the unit tests here:

--- FAIL: TestFetchKeybasePubkeys (0.12s)
    keybase_test.go:40: fingerprints do not match; expected 
        []string{"0f801f518ec853daff611e836528efcac6caa3db", "91a6e7f85d05c65630bef18951852d87348ffc4c"}
        got
        []string{"0f801f518ec853daff611e836528efcac6caa3db", "c874011f0ab405110d02105534365d9472d7468f"}

It does not appear the IAM Access Key and User Login Profile acceptance testing is affected:

--- PASS: TestAccAWSUserLoginProfile_keybaseDoesntExist (10.31s)
--- PASS: TestAccAWSUserLoginProfile_notAKey (10.67s)
--- PASS: TestAccAWSAccessKey_encrypted (16.16s)
--- PASS: TestAccAWSAccessKey_basic (16.64s)
--- PASS: TestAccAWSUserLoginProfile_keybase (16.81s)
--- PASS: TestAccAWSUserLoginProfile_PasswordLength (17.00s)
--- PASS: TestAccAWSUserLoginProfile_basic (23.11s)
--- PASS: TestAccAWSAccessKey_Status (30.26s)
ghost commented 3 years ago

This has been released in version 3.38.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

github-actions[bot] commented 3 years ago

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.