aws_eks_node_group missing suspended_processes support like AZRebalance

hashicorp / terraform-provider-aws

The AWS Provider enables Terraform to manage AWS resources.

https://registry.terraform.io/providers/hashicorp/aws

Mozilla Public License 2.0

9.82k stars 9.17k forks source link

aws_eks_node_group missing suspended_processes support like AZRebalance #21692

Open devopsmash opened 2 years ago

devopsmash commented 2 years ago

Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

while the resource aws_autoscaling_group has suspended_processes like:

  suspended_processes = ["AZRebalance"]

The resource aws_eks_node_group doesn't support suspended_processes

It seems that the Managed Autoscale group has this option

Can you add this support for the resource aws_eks_node_group?

New or Affected Resource(s)

aws_eks_node_group

Natalique commented 2 years ago

Any updates on this maybe? We've been experiencing some issues with Cluster autoscaler and AZRebalance

naor919 commented 2 years ago

Same issue for me.

eclivus commented 2 years ago

I can't help you on coding it, but it I was able to do it with a null_resource command using aws autoscaling suspend-processes --auto-scaling-group-name ${each.value} --scaling-processes AZRebalance Auto scaling group names can be accessed through terraform-provider-aws module (I used a data source however for simplicity).

mattburgess commented 1 year ago

Unfortunately, there's no support for passing down the desired suspended_processes through to the underlying ASG in the EKS API. Given that the underlying ASG isn't managed by Terraform, I think that @eclivus' suggestion is the best option right now. If anyone interested in this feature has a support contract with AWS it might be worth you trying to engage with your TAM to see if the feature can be put on the EKS backlog. There's a related roadmap item https://github.com/aws/containers-roadmap/issues/1453 (with a similar null_resource workaround) which it might be worth folks tracking and/or providing input to.